Send returning players their saved position on connect, rather than 0,0#97
Open
Send returning players their saved position on connect, rather than 0,0#97
Conversation
Nebual
force-pushed
the
load-saved-position
branch
from
c250c78 to
543a4c8
Compare
Refactor out send_sector()
Nebual
force-pushed
the
load-saved-position
branch
from
543a4c8 to
b79d7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like there was some confusion between
self.positionandposition.Also extracted out send_sector() (really that whole networking layer needs to be split up...), and added some recovery if the player falls through the world (on reconnect, place them on top of where they were)